Store Page
Slay the Spire
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Slay the Spire

Store Page
Slay the Spire >  Workshop > Nichilas's Workshop > A Better Note > Discussions
A Better Note
Description Discussions1 Comments58 Change Notes
 This topic has been pinned, so it's probably important
Nichilas  [developer] 6 Apr, 2020 @ 9:23pm
Bug Reports
Please report any bugs or crashes you've encountered here. If you have them, crash logs are also very helpful!
< >
Showing 1-13 of 13 comments
m11kire 8 Apr, 2020 @ 2:49pm 
i'm having a crash to desktop on entering a ? spot, looking at the log gives me the below. if you like i can email or pastebin the entire log


java.lang.IllegalArgumentException: n must be positive
at com.badlogic.gdx.math.RandomXS128.nextLong(RandomXS128.java:110) ~[desktop-1.0.jar:?]
at com.badlogic.gdx.math.RandomXS128.nextInt(RandomXS128.java:99) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.random.Random.random(Random.java:65) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.getShrine(AbstractDungeon.java:2416) ~[?:?]
at betterNote.patches.NotePatch$NotePatchGenerate.Prefix(NotePatch.java:28) ~[BetterNote.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.generateEvent(AbstractDungeon.java) ~[?:?]
at com.megacrit.cardcrawl.rooms.EventRoom.onPlayerEntry(EventRoom.java:22) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.nextRoomTransition(AbstractDungeon.java:2262) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.nextRoomTransition(AbstractDungeon.java:2109) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.updateFading(AbstractDungeon.java:2828) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2497) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:879) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:427) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126) [desktop-1.0.jar:?]
#1
Nichilas  [developer] 8 Apr, 2020 @ 10:46pm 
Originally posted by m11kire:
i'm having a crash to desktop on entering a ? spot, looking at the log gives me the below. if you like i can email or pastebin the entire log


java.lang.IllegalArgumentException: n must be positive
at com.badlogic.gdx.math.RandomXS128.nextLong(RandomXS128.java:110) ~[desktop-1.0.jar:?]
at com.badlogic.gdx.math.RandomXS128.nextInt(RandomXS128.java:99) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.random.Random.random(Random.java:65) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.getShrine(AbstractDungeon.java:2416) ~[?:?]
at betterNote.patches.NotePatch$NotePatchGenerate.Prefix(NotePatch.java:28) ~[BetterNote.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.generateEvent(AbstractDungeon.java) ~[?:?]
at com.megacrit.cardcrawl.rooms.EventRoom.onPlayerEntry(EventRoom.java:22) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.nextRoomTransition(AbstractDungeon.java:2262) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.nextRoomTransition(AbstractDungeon.java:2109) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.updateFading(AbstractDungeon.java:2828) ~[?:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2497) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:879) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:427) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126) [desktop-1.0.jar:?]
Hi, thank you for your report. This seems to have been a bug that occurs when the shrine event list is entirely exhausted. I have pushed an update that addresses this issue. You might have to restart your current run. Let me know if you are still having issues.
#2
CardstockCaster1 11 Jul, 2020 @ 11:41am 
Hi, im experiencing crashing whenever i store a card from The Hermit mod
Unsure if its an issue with hermit, or this mod, or just them interacting poorly
#3
Nichilas  [developer] 11 Jul, 2020 @ 2:23pm 
Hello, thank you for your report. I have many instances of people storing hermit cards without issue, so my guess is it might be an error with that specific card. Which card exactly is it?
#4
Tess 16 Jul, 2020 @ 9:14am 
I'll comment in here, here is the relevant portion of my crash log. The conditions were that I had no stored card and I attempted to use the "store card" option. I can give you the rest if you'd like me to pastebin it or something

16:49:16.939 INFO dungeons.AbstractDungeon> GENERATING ROOM: EVENT 16:49:16.950 DEBUG steam.SteamIntegration> Setting Rich Presence: The Silent - Floor 24 16:49:16.951 INFO betterNote.BetterNote> Forcing Note Event over Bonfire Elementals 16:49:16.951 INFO dungeons.AbstractDungeon> Removed event: NoteForYourself from pool. 16:49:16.951 DEBUG helpers.File> Successfully saved file=G:\Program Files (x86)\Steam\steamapps\common\SlayTheSpire\preferences\STSDataTheSilent 16:49:16.951 DEBUG helpers.FileSaver> Dequeue: qsize=0 file=saves\THE_SILENT.autosave 16:49:16.951 DEBUG helpers.File> Attempting to save file=G:\Program Files (x86)\Steam\steamapps\common\SlayTheSpire\saves\THE_SILENT.autosave 16:49:16.958 WARN basemod.BaseMod> NoteForYourself trying to receive card "None" which does not exist. Defaulting to Iron Wave. 16:49:16.974 DEBUG helpers.File> Successfully saved file=G:\Program Files (x86)\Steam\steamapps\common\SlayTheSpire\saves\THE_SILENT.autosave 16:49:20.923 INFO audio.TempMusic> Disposing TempMusic: SHRINE 16:49:22.689 INFO core.CardCrawlGame> Exception occurred in CardCrawlGame render method! 16:49:22.689 ERROR core.CardCrawlGame> Exception caught java.lang.NullPointerException: null at com.megacrit.cardcrawl.events.AbstractEvent.logMetricObtainCardAndLoseCard(AbstractEvent.java:527) ~[?:?] at betterNote.events.BetterNoteEvent.update(BetterNoteEvent.java:147) ~[BetterNote.jar:?] at com.megacrit.cardcrawl.rooms.EventRoom.update(EventRoom.java:30) ~[desktop-1.0.jar:?] at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2512) ~[?:?] at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:879) ~[?:?] at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:427) [?:?] at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225) [?:?] at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126) [desktop-1.0.jar:?] 16:49:22.706 INFO core.CardCrawlGame> PAUSE() 16:49:22.706 INFO core.CardCrawlGame> Game shutting down...
#5
Nichilas  [developer] 16 Jul, 2020 @ 9:44am 
That is sufficient, thank you. Do you have A better Sensory Stone installed? I think this is related to a bug I had with cards with longer cardIDs (usually modded cards since they include the mod name and the card name) being removed would mess up the base games event function for the note event. I patched this a little bit ago, so you shouldn't be encountering this anymore if that's the case. Let me know if this happens again!
#6
Tess 17 Jul, 2020 @ 10:47am 
No I do not have that mod installed, the crash also happens no matter what card I store even if it is in the base game
#7
Nichilas  [developer] 17 Jul, 2020 @ 10:55am 
This is happening after the latest update, or that was the old behavior?
#8
Tess 18 Jul, 2020 @ 8:07am 
This was happening after the latest update and not before to my knowledge. Before the update I always did the take and give open though so it's possible this exact scenario (no card stored, attempting to just store one) would have triggered it and I wouldn't know
#9
CardstockCaster1 31 Jul, 2020 @ 2:02am 
Originally posted by Nichilas:
Hello, thank you for your report. I have many instances of people storing hermit cards without issue, so my guess is it might be an error with that specific card. Which card exactly is it?

I apologize for taking so long to respond to this, but i had tested it, and the issue persisted even with base game characters, and with other mods removed
#10
Nichilas  [developer] 31 Jul, 2020 @ 10:35am 
No worries, thank you for confirming! Do you have the crash log, or can you reload the event to obtain them? I haven't been able to recreate this bug under any circumstances, so without more information, I can't determine anything.
Additionally, I suppose I should ask you to make sure you're using the most updated version.
Last edited by Nichilas; 31 Jul, 2020 @ 10:41am
#11
CardstockCaster1 1 Aug, 2020 @ 10:39pm 
I will install the mod again and test it!
im unsure what exactly was causing the issue, but it was not just in storing it, but doing any interaction.

i want to correct myself and say that while i did not deactivate the hermit, i was not playing as him, so at the least, i know it wasnt a card based interaction
#12
Nichilas  [developer] 1 Aug, 2020 @ 11:21pm 
Okay, if it wasn't just storing, it could be a different bug from the one people encountered 5 or 6 patches ago. Keep me posted.
#13
< >
Showing 1-13 of 13 comments
Per page: 1530 50